jbang devmode not honoring properties

[maxandersen]

Describe the bug

I think since #43160 jbang -Dquarkus.dev some.java does not honor Q:CONFIG.

///usr/bin/env jbang "$0" "$@" ; exit $?
//DEPS io.quarkus.platform:quarkus-bom:3.16.1@pom
//DEPS io.quarkus:quarkus-picocli

//Q:CONFIG quarkus.banner.enabled=false
//Q:CONFIG quarkus.log.level=ERROR
import io.quarkus.logging.Log;
import picocli.CommandLine.Command;

@Command
public class basicdev implements Runnable {
  


    @Override
    public void run() {
        System.out.println("You should see ERROR, but no WARN or INFO");
        Log.warn("This is a WARN message");
        Log.info("This is an INFO message");
        Log.error("This is an ERROR message");
    }
}

run above using jbang --fresh basicdev.java and it will only print ERROR logging, but run it with jbang --fresh -Dquarkus.dev basicdev.java it prints warn,info and error. As if it completely ignores Q:CONFIG

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @quarkusio/devtools (jbang)

[radcortez]

Ok, it seems that Dev Mode uses a different path:

quarkus/core/launcher/src/main/java/io/quarkus/launcher/JBangIntegration.java

Lines 27 to 48 in e12a377

	if (Boolean.getBoolean("quarkus.dev")) {
	System.clearProperty("quarkus.dev"); //avoid unknown config key warnings
	HashMap<String, byte[]> files = new HashMap<>();
	ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
	DataOutputStream dataOutputStream = new DataOutputStream(outputStream);
	//pom file contents
	String pomContents = String.join("\n", Files.readAllLines(pomFile));
	dataOutputStream.writeUTF(pomContents);
	//Source file locations
	dataOutputStream.writeUTF(System.getProperty("jbang.source"));
	dataOutputStream.writeInt(originalDeps.size());
	for (Map.Entry<String, Path> i : originalDeps) {
	dataOutputStream.writeUTF(i.getKey());
	dataOutputStream.writeUTF(i.getValue().toAbsolutePath().toString());
	}
	dataOutputStream.close();
	files.put("jbang-dev.dat", outputStream.toByteArray());
	HashMap<String, Object> ret = new HashMap<>();
	ret.put("files", files);
	ret.put("main-class", "io.quarkus.launcher.JBangDevModeLauncher");
	return ret;
	}

[maxandersen]

well that for sure explains why its not honoring any config as it returns early.

Now I'm just wondering why it ever worked ...and how we can go about passing in Q:CONFIG properties in devmode...if at all.

[radcortez]

It may have worked before that code?

I'm proposing a fix in #44415, which requires us to parse the source file again because we lose the comments section parameter.

Also, can you confirm that the hot reload is working? When I change the file, I get an error: Cannot initialize file manager.

[aloubyansky]

I guess we are lacking some integration tests