Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.16.0: ExtendedQuarkusVertxHttpMetrics not found in tests #44125

Closed
famod opened this issue Oct 28, 2024 · 4 comments · Fixed by #44072
Closed

3.16.0: ExtendedQuarkusVertxHttpMetrics not found in tests #44125

famod opened this issue Oct 28, 2024 · 4 comments · Fixed by #44072

Comments

@famod
Copy link
Member

famod commented Oct 28, 2024

Describe the bug

Upgrading from 3.15.1 to 3.16.0 results in a ClassNotFoundException w.r.t. ExtendedQuarkusVertxHttpMetrics while running tests in many modules of my multi module maven project.
All affected modules seem to have in common that they don't have quarkus-vertx-http on the classpath.

Expected behavior

No exception.

Actual behavior

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:632)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:716)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
	at io.quarkus.runtime.Application.start(Application.java:101)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.runner.bootstrap.StartupActionImpl.run(StartupActionImpl.java:305)
	at io.quarkus.test.junit.QuarkusTestExtension.doJavaStart(QuarkusTestExtension.java:245)
	at io.quarkus.test.junit.QuarkusTestExtension.ensureStarted(QuarkusTestExtension.java:599)
	at io.quarkus.test.junit.QuarkusTestExtension.beforeAll(QuarkusTestExtension.java:649)
	... 1 more
Caused by: java.lang.NoClassDefFoundError: io/quarkus/vertx/http/runtime/ExtendedQuarkusVertxHttpMetrics
	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:531)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:490)
	at io.quarkus.opentelemetry.runtime.tracing.intrumentation.vertx.OpenTelemetryVertxMetricsFactory.metrics(OpenTelemetryVertxMetricsFactory.java:29)
	at io.vertx.core.spi.VertxMetricsFactory.init(VertxMetricsFactory.java:50)
	at io.vertx.core.impl.VertxBuilder.initProviders(VertxBuilder.java:284)
	at io.vertx.core.impl.VertxBuilder.init(VertxBuilder.java:275)
	at io.quarkus.vertx.core.runtime.VertxCoreRecorder.initialize(VertxCoreRecorder.java:254)
	at io.quarkus.vertx.core.runtime.VertxCoreRecorder$VertxSupplier.get(VertxCoreRecorder.java:681)
	at io.quarkus.vertx.core.runtime.VertxCoreRecorder$VertxSupplier.get(VertxCoreRecorder.java:660)
	at io.quarkus.opentelemetry.runtime.OpenTelemetryRecorder.storeVertxOnContextStorage(OpenTelemetryRecorder.java:48)
	at io.quarkus.deployment.steps.OpenTelemetryProcessor$createOpenTelemetry193862828.deploy_0(Unknown Source)
	at io.quarkus.deployment.steps.OpenTelemetryProcessor$createOpenTelemetry193862828.deploy(Unknown Source)
	... 8 more
Caused by: java.lang.ClassNotFoundException: io.quarkus.vertx.http.runtime.ExtendedQuarkusVertxHttpMetrics
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:542)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:490)
	... 22 more

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

3.16.0

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

I've I had to guess I'd say it's caused by https://github.com/quarkusio/quarkus/pull/43919/files#diff-961d9cea05a0737ae8c64bb818127d66f4e8d2e70a3b1b3a59a78ce623667fb7

Copy link

quarkus-bot bot commented Oct 28, 2024

/cc @ebullient (metrics), @jmartisk (metrics)

@gsmet
Copy link
Member

gsmet commented Oct 28, 2024

Hey @famod ! Can you try with #44072?

@famod famod linked a pull request Oct 28, 2024 that will close this issue
@famod
Copy link
Member Author

famod commented Oct 28, 2024

Hi @gsmet! Fix confirmed, thanks for the pointer.

@famod famod closed this as completed Oct 28, 2024
@gsmet
Copy link
Member

gsmet commented Oct 28, 2024

Thanks for opening this. I think I will build a 3.16.1 before the official release.

@gsmet gsmet added this to the 3.16.1 milestone Oct 28, 2024
@gsmet gsmet modified the milestones: 3.16.1, 3.15.2 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants