Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unsupported Quartz scheduler properties #40850

Closed
michelkaeser opened this issue May 27, 2024 · 6 comments · Fixed by #44084
Closed

Allow unsupported Quartz scheduler properties #40850

michelkaeser opened this issue May 27, 2024 · 6 comments · Fixed by #44084
Labels
Milestone

Comments

@michelkaeser
Copy link
Contributor

Description

Similar to how the Hibernate extension allows setting unsupported properties, the Quartz scheduler (why not all extensions? 😃) should allow setting unsupported properties.

Personally I am interested in enabling the JMX export via org.quartz.scheduler.jmx.export = true which I am unable to enable otherwise.

Implementation ideas

quarkus.quartz.unsupported-properties should be available similar to quarkus.hibernate-orm.unsupported-properties.

@michelkaeser michelkaeser added the kind/enhancement New feature or request label May 27, 2024
Copy link

quarkus-bot bot commented May 27, 2024

/cc @machi1990 (quartz), @manovotn (quartz,scheduler), @mkouba (quartz,scheduler)

@mkouba
Copy link
Contributor

mkouba commented May 28, 2024

@michelkaeser That's a good idea. Would you care to work on this feature? ;-)

@geoand
Copy link
Contributor

geoand commented May 28, 2024

I would call them quarkus.quartz.additional-properties really instead of unsupported-properties

@mkouba
Copy link
Contributor

mkouba commented May 28, 2024

I would call them quarkus.quartz.additional-properties really instead of unsupported-properties

I don't know. It might make sense to keep it consistent with quarkus.hibernate-orm.unsupported-properties 🤷.

@geoand
Copy link
Contributor

geoand commented May 28, 2024

Right, consistency is important, but I am pretty sure that in Hibernate they are called unsupported because there is no guarantee they will work, whereas AFAIU in Quartz the situation is different

@mkouba
Copy link
Contributor

mkouba commented May 28, 2024

Right, consistency is important, but I am pretty sure that in Hibernate they are called unsupported because there is no guarantee they will work, whereas AFAIU in Quartz the situation is different

I'm not so sure TBH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants