Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micrometer performance improvements #40507

Closed
4 tasks done
brunobat opened this issue May 7, 2024 · 4 comments
Closed
4 tasks done

Micrometer performance improvements #40507

brunobat opened this issue May 7, 2024 · 4 comments
Labels
area/metrics kind/enhancement New feature or request

Comments

@brunobat
Copy link
Contributor

brunobat commented May 7, 2024

Description

The current way we are using Micrometer has negative performance impacts, as described in this blog post from @tsegismont:
https://vertx.io/blog/micrometer-metrics-performance/

In a nutshell:

  • fil­ter­ing tags up front in­stead of using a Mi­crom­e­ter MeterFilter
  • avoid­ing re­dun­dant copies when com­bin­ing tags
  • look­ing up me­ters once if their tags are known in ad­vance
  • use a MeterProvider when some tags can be de­ter­mined only after an event oc­cured.

This issue will be the parent issue of many enhancements that should happen on the quarkus-micrometer extension, mainly in the io.quarkus.micrometer.runtime.binder package classes.

Will create an issue per package because this can be a good first issue for someone. To help with this, the Vert.x package PR will serve as a reference implementation.

List of child issues:

You just need to pick one for you.

@brunobat brunobat added the kind/enhancement New feature or request label May 7, 2024
Copy link

quarkus-bot bot commented May 7, 2024

/cc @ebullient (micrometer)

@brunobat
Copy link
Contributor Author

This is done

@tsegismont
Copy link
Contributor

@brunobat great! Have you been able to measure improvements?

@brunobat
Copy link
Contributor Author

Not yet. I' m still working on the performance setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants