You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A lot of code samples has methods, which should return String but has no return statement. It it somehow bad to have an example code that cannot be compiled.
In my POV I don't think this is a problem as the comments there states that this is for user modification. We can probably add just return statetments with blank string but I personaly don't like it as it don't have any added value + this is reference guide not the guide to follow code and get results.
Otherwise other problem are adressed in PR linked ^
Describe the bug
Found issues in https://quarkus.io/version/main/guides/security-openid-connect-client-reference
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#use-oidcclient-directly . In the code sample there is import
import jakarta.inject.PostConstruct;
which does not work, IMHO it should beimport jakarta.annotation.PostConstruct;
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#named-oidc-clients - First code sample is missing imports for
@NamedOidcClient
andOidcClient
:https://quarkus.io/version/main/guides/security-openid-connect-client-reference#oidc-client-reactive-filter - First and last code samples has unused import
import org.eclipse.microprofile.rest.client.annotation.RegisterProvider;
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#integration-testing-oidc-client - Section about testing could use an actual test example. It at least looks strange to have everything setup in detail but no actual test.
Chapter "Token Propagation Reactive" is there twice, it should be unified in one:
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#token-propagation-reactive
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#reactive-token-propagation
Code samples is several sections are missing imports for
@GET
and@Path
:https://quarkus.io/version/main/guides/security-openid-connect-client-reference#oidc-client-reactive-filter
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#token-propagation-reactive
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#restclient-accesstokenrequestfilter
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#restclient-jsonwebtokenrequestfilter
String
but has no return statement. It it somehow bad to have an example code that cannot be compiled.https://quarkus.io/version/main/guides/security-openid-connect-client-reference#use-oidcclient-directly
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#inject-tokens
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#use-oidc-clients
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#named-oidc-clients
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#oidc-client-filter
Expected behavior
No response
Actual behavior
No response
How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: