Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: OpenID Connect (OIDC) and OAuth2 Client and Filters Reference Guide #37430

Closed
mocenas opened this issue Nov 30, 2023 · 2 comments · Fixed by #43970
Closed

Docs: OpenID Connect (OIDC) and OAuth2 Client and Filters Reference Guide #37430

mocenas opened this issue Nov 30, 2023 · 2 comments · Fixed by #43970
Labels
Milestone

Comments

@mocenas
Copy link
Contributor

mocenas commented Nov 30, 2023

Describe the bug

Found issues in https://quarkus.io/version/main/guides/security-openid-connect-client-reference

import io.quarkus.oidc.client.NamedOidcClient;
import io.quarkus.oidc.client.OidcClient;
import jakarta.ws.rs.GET;
import jakarta.ws.rs.Path;

https://quarkus.io/version/main/guides/security-openid-connect-client-reference#oidc-client-reactive-filter
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#token-propagation-reactive
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#restclient-accesstokenrequestfilter
https://quarkus.io/version/main/guides/security-openid-connect-client-reference#restclient-jsonwebtokenrequestfilter

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@mocenas mocenas added the kind/bug Something isn't working label Nov 30, 2023
Copy link

quarkus-bot bot commented Nov 30, 2023

/cc @pedroigor (oidc), @sberyozkin (oidc)

@jedla97
Copy link
Contributor

jedla97 commented Oct 18, 2024

Just note after going through guide

A lot of code samples has methods, which should return String but has no return statement. It it somehow bad to have an example code that cannot be compiled.

In my POV I don't think this is a problem as the comments there states that this is for user modification. We can probably add just return statetments with blank string but I personaly don't like it as it don't have any added value + this is reference guide not the guide to follow code and get results.

Otherwise other problem are adressed in PR linked ^

@github-project-automation github-project-automation bot moved this from To do to Done in Quarkus Documentation Oct 18, 2024
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 18, 2024
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.0 Oct 21, 2024
@rsvoboda rsvoboda modified the milestones: 3.16.0, 3.15.2 Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

5 participants