Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for usage of javax.persistence configuration properties in Hibernate extensions #31130

Open
Sanne opened this issue Feb 13, 2023 · 1 comment
Labels

Comments

@Sanne
Copy link
Member

Sanne commented Feb 13, 2023

Description

The current Hibernate ORM builds are lenient on configuration properties to be prefixed with either javax.persistence or jakarta.persistence; in most cases (it's not bullet-proof currently) the ORM will detect ambiguity and also log warnings, but such safeguards in upstream ORM aren't enough in Quarkus as we also need to handle implicitly set properties and the potential for these to be overriden.

Implementation ideas

We should be highly paranoid in accepting any javax.persistence, and check both:

  • unsupported properties in applications.properties
  • anything specified in a persistence.xml

Wondering about environment/system properties; I don't think they are affected but it might be worth checking - not remembering for sure.

At very least we shoul log a warning; wondering if we shouldn't fail outright - might actually be less tricky for end users to have a clear error rather than undefined behaviour.

@Sanne Sanne added kind/enhancement New feature or request area/hibernate-orm Hibernate ORM labels Feb 13, 2023
@quarkus-bot quarkus-bot bot added the area/persistence OBSOLETE, DO NOT USE label Feb 13, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 13, 2023

/cc @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

@yrodiere yrodiere added this to the 3.0 - main milestone Feb 14, 2023
@gsmet gsmet removed this from the 3.0.0.Alpha5 milestone Mar 7, 2023
@yrodiere yrodiere removed the area/persistence OBSOLETE, DO NOT USE label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

3 participants