Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle plugin output tracking breaks if quarkus.package.output-directory is configured #28897

Closed
britter opened this issue Oct 28, 2022 · 4 comments · Fixed by #29971
Closed
Labels
area/gradle Gradle kind/bug Something isn't working
Milestone

Comments

@britter
Copy link
Contributor

britter commented Oct 28, 2022

Describe the bug

The QuarkusBuild task does not provide a way to reconfigure it's output location. Instead it's hardcoded to $buildDir/quarkus-app. At the same time, users can configure the output location by setting the quarkus.package.output-directory. This will cause the build to create the output in a different location. However Gradle is unaware of this location, so UP-TO-DATE checking and build caching breaks because Gradle will track the location returned from QuarkusBuild.getFastJar(). Furthermore it's not possible to easily consume QuarkusBuild output from another task, because QuarkusBuild is unaware of the changed location.

Expected behavior

When changing the output location via quarkus.package.output-directory this should also change the value returned from QuarkusBuild.getFastJar() accordingly. #28896 is related to this.

Actual behavior

Gradle is unaware of changes to QuarkusBuild output location configured by quarkus.package.output-directory

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@britter britter added the kind/bug Something isn't working label Oct 28, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 28, 2022

/cc @glefloch, @quarkusio/devtools

@quarkus-bot quarkus-bot bot added the area/gradle Gradle label Oct 28, 2022
@glefloch
Copy link
Member

Thanks for reporting this issue, we need to take care of that variable.

@geoand
Copy link
Contributor

geoand commented Nov 2, 2022

@jacobdotcosta would you be interested in this?

@jacobdotcosta
Copy link
Contributor

Yes, I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gradle Gradle kind/bug Something isn't working
Projects
None yet
4 participants