Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry SDK Autoconfigure #26444

Closed
5 tasks done
radcortez opened this issue Jun 29, 2022 · 3 comments
Closed
5 tasks done

OpenTelemetry SDK Autoconfigure #26444

radcortez opened this issue Jun 29, 2022 · 3 comments
Assignees
Labels
area/tracing kind/enhancement New feature or request kind/epic Large issue with links to sub-issues

Comments

@radcortez
Copy link
Member

radcortez commented Jun 29, 2022

Description

Provide support for OpenTelemetry SDK Autoconfigure:
https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/autoconfigure/README.md

Scheduled work:

We identified improvements (see comments bellow) to the initial PR #26760
Leading to this phased execution plan:

Required by:

@radcortez radcortez added the kind/enhancement New feature or request label Jun 29, 2022
@radcortez radcortez self-assigned this Jun 29, 2022
@brunobat brunobat self-assigned this Jul 7, 2022
@brunobat
Copy link
Contributor

brunobat commented Jul 7, 2022

The idea is to mirror the OTel side configs in order to better document the features on our side. This will require some work on our side but will improve the dev experience because there will no ambiguity on the working configs and which OTel config version is being supported.

@brunobat
Copy link
Contributor

brunobat commented Sep 19, 2022

The existing WIP PR tried to allign as best as possible the current OTel extension and the OTel side autoconfiguration. However, the PR #26760 will be closed and incremental PRs will be done because:

  • PR is already too big and difficult to review
  • We learned that the resulting configuration objects are confusing. There is no clear separation from build and runtime configs.
  • This doesn't solve the current dev mode auto-reload problem, which will require build and configuration changes. Most pieces of the PR will be moved to PRs with the plan detailed in the 1st comment.

@brunobat
Copy link
Contributor

Finally done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracing kind/enhancement New feature or request kind/epic Large issue with links to sub-issues
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants