Misconfigured TCCL for @TestFactory dynamic tests breaks RestAssured since Quarkus 1.5.0 #10435
Labels
Milestone
Comments
bertm
changed the title
|
For your convenience, the full stack trace of the error (with |
|
Looks like Quarkus 1.6.0.Final has just been released. Reproducible on 1.6.0.Final as well. |
|
/cc @geoand |
|
I don't think there is much we can do about this case, but I'll have a look on Monday |
|
I looked at this and there isn't anything we can do, as the dynamic test doesn't run in the ClassLoader that QuarkusTest sets up |
|
The difference between 1.4.2 and 1.5.0 in this respect is that in 1.4.2 Unfortunately |
|
Hello , Is this issue was ever resolved or do you have any alternative to make it work ? I am also facing similar exception - |
|
@holly-cummins @geoand maybe something we will be able to close when we update to the new JUnit with CL fixes? Thought you might have a list :). |
|
Let's hope we'll be able to update. The more I think about it, the more I think it's going to be pretty difficult.... |
|
Any news here or at least a workaround? Important part of the stack trace is: |
|
I can no longer reproduce this starting from 2.1.2.Final. I suppose this was fixed with #19293. return dynamicTest("exampleDynamicTest", () -> {
Thread.currentThread().setContextClassLoader(getClass().getClassLoader());
// actual test code goes here
});If that does not help, you are probably facing another issue. |
|
you are right... It was another problem. Thanks for your hint! I build up a Test like so: this leads to running the testee in the The code under test obviously has to run in the |
|
Is this still an issue? |
|
@geoand asks:
@bertm said:
I've just tried the reproducer with 3.15.1, and it still works fine. However, our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
RestAssured no longer initializes correctly when used in a dynamic test (
@TestFactorywithDynamicTest) due to a classloader mismatch. I discovered this when upgrading from 1.4.2.Final to 1.5.2.Final recently.RestAssured uses the TCCL to initialize its Jackson ObjectMapper. In simple
@Testtest cases, and in the execution of the@TestFactorymethod, the TCCL is theQuarkus Base Runtime Classloader. During the execution of the dynamic test cases returned by the@TestFactorymethod, the TCCL is the system classloader since 1.5.0.This leads to a mismatch between to RestAssured.class ClassLoader and the TCCL when RestAssured is used, leading to unexpected errors in test execution:
Expected behavior
@TestFactory-produced dynamic test cases.@TestFactory-produced dynamic test cases is the same as when executing@Testtest cases.Actual behavior
@TestFactory-produced dynamic test cases.@TestFactory-produced dynamic test cases differs from the one during execution of@Testtest cases.To Reproduce
Steps to reproduce the behavior:
mvn io.quarkus:quarkus-maven-plugin:1.5.2.Final:create \ -DprojectGroupId=org.acme \ -DprojectArtifactId=rest-json-quickstart \ -DclassName="org.acme.rest.json.FruitResource" \ -Dpath="/fruits" \ -Dextensions="resteasy-jackson" \ -DplatformVersion=1.5.2.Finalmvn clean verifyConfiguration
Not applicable.
Environment (please complete the following information):
uname -aorver:java -version: reproduced on various JREs, but here's one:mvnw --versionorgradlew --version):Additional context
The exact same test case works fine (that is, does nothing meaningful instead of throwing an error) on Quarkus 1.4.2. Substituting
platformVersion=1.5.2.FinalforplatformVersion=1.4.2.Finalin step 1. is sufficient to make the test succeed.The text was updated successfully, but these errors were encountered: