From db9ffd71f3a94108ee8a64b57859c9eee1c250f4 Mon Sep 17 00:00:00 2001
From: Foivos Zakkak <fzakkak@redhat.com>
Date: Mon, 15 May 2023 11:45:18 +0300
Subject: [PATCH] Do not attempt to detect container runtime in native-sources
 build

Closes: #33161
---
 .../pkg/steps/NativeImageBuildStep.java       | 12 ++++++-
 .../pkg/steps/NoopNativeImageBuildRunner.java | 34 +++++++++++++++++++
 .../main/asciidoc/building-native-image.adoc  |  5 +--
 3 files changed, 48 insertions(+), 3 deletions(-)
 create mode 100644 core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NoopNativeImageBuildRunner.java

diff --git a/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
index e4c313fcb650f..0f84c2abd2dbd 100644
--- a/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
+++ b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
@@ -329,7 +329,7 @@ private String getResultingExecutableName(String nativeImageName, boolean isCont
     /**
      * Resolves the runner factory. Happens quite early, *before* the build.
      */
-    @BuildStep
+    @BuildStep(onlyIf = NativeBuild.class)
     public NativeImageRunnerBuildItem resolveNativeImageBuildRunner(NativeConfig nativeConfig) {
         boolean isExplicitContainerBuild = nativeConfig.containerBuild()
                 .orElse(nativeConfig.containerRuntime().isPresent() || nativeConfig.remoteContainerBuild());
@@ -353,6 +353,16 @@ public NativeImageRunnerBuildItem resolveNativeImageBuildRunner(NativeConfig nat
         return new NativeImageRunnerBuildItem(new NativeImageBuildLocalContainerRunner(nativeConfig));
     }
 
+    /**
+     * Creates a dummy runner for native-sources builds. This allows the creation of native-source jars without
+     * requiring podman/docker or a local native-image installation.
+     */
+    @BuildStep(onlyIf = NativeSourcesBuild.class)
+    public NativeImageRunnerBuildItem dummyNativeImageBuildRunner(NativeConfig nativeConfig) {
+        boolean explicitContainerBuild = nativeConfig.isExplicitContainerBuild();
+        return new NativeImageRunnerBuildItem(new NoopNativeImageBuildRunner(explicitContainerBuild));
+    }
+
     private void copyJarSourcesToLib(OutputTargetBuildItem outputTargetBuildItem,
             CurateOutcomeBuildItem curateOutcomeBuildItem) {
         Path targetDirectory = outputTargetBuildItem.getOutputDirectory()
diff --git a/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NoopNativeImageBuildRunner.java b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NoopNativeImageBuildRunner.java
new file mode 100644
index 0000000000000..f1c289b1f3852
--- /dev/null
+++ b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NoopNativeImageBuildRunner.java
@@ -0,0 +1,34 @@
+package io.quarkus.deployment.pkg.steps;
+
+import java.nio.file.Path;
+import java.util.List;
+
+public class NoopNativeImageBuildRunner extends NativeImageBuildRunner {
+
+    private static final String MESSAGE = "NoopNativeImageBuildRunner is not meant to be used to perform an actual build.";
+    private final boolean isContainer;
+
+    public NoopNativeImageBuildRunner(boolean isContainer) {
+        this.isContainer = isContainer;
+    }
+
+    @Override
+    public boolean isContainer() {
+        return isContainer;
+    }
+
+    @Override
+    protected String[] getGraalVMVersionCommand(List<String> args) {
+        throw new UnsupportedOperationException(MESSAGE);
+    }
+
+    @Override
+    protected String[] getBuildCommand(Path outputDir, List<String> args) {
+        throw new UnsupportedOperationException(MESSAGE);
+    }
+
+    @Override
+    protected void objcopy(Path outputDir, String... args) {
+        throw new UnsupportedOperationException(MESSAGE);
+    }
+}
diff --git a/docs/src/main/asciidoc/building-native-image.adoc b/docs/src/main/asciidoc/building-native-image.adoc
index 8620002a85b7a..3e0243d52d816 100644
--- a/docs/src/main/asciidoc/building-native-image.adoc
+++ b/docs/src/main/asciidoc/building-native-image.adoc
@@ -786,10 +786,11 @@ $ ./mvnw clean package -Dquarkus.package.type=native-sources -Dquarkus.native.co
 cd target/native-sources
 docker run \
   -it \
+  --user $(id -ur):$(id -gr) \
   --rm \
-  --v $(pwd):/work \# <1>
+  -v $(pwd):/work \# <1>
   -w /work \# <2>
-  --entrypoint bin/sh \
+  --entrypoint /bin/sh \
   $(cat native-builder.image) \# <3>
   -c "native-image $(cat native-image.args) -J-Xmx4g"# <4>
 ----