Skip to content

Commit 7814ea5

Browse files
authored
Merge pull request #30828 from sberyozkin/oidc_session_cookie_same_site_lax
Make OIDC session cookie same site lax by default
2 parents 7fe17cc + 1501eb8 commit 7814ea5

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

extensions/oidc/runtime/src/main/java/io/quarkus/oidc/OidcTenantConfig.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -769,8 +769,8 @@ public enum ResponseMode {
769769
/**
770770
* SameSite attribute for the session cookie.
771771
*/
772-
@ConfigItem(defaultValue = "strict")
773-
public CookieSameSite cookieSameSite = CookieSameSite.STRICT;
772+
@ConfigItem(defaultValue = "lax")
773+
public CookieSameSite cookieSameSite = CookieSameSite.LAX;
774774

775775
/**
776776
* If this property is set to 'true' then an OIDC UserInfo endpoint will be called.

integration-tests/oidc-code-flow/src/main/resources/application.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ quarkus.oidc.tenant-https.authentication.cookie-suffix=test
107107
quarkus.oidc.tenant-https.authentication.error-path=/tenant-https/error
108108
quarkus.oidc.tenant-https.authentication.pkce-required=true
109109
quarkus.oidc.tenant-https.authentication.pkce-secret=eUk1p7UB3nFiXZGUXi0uph1Y9p34YhBU
110-
quarkus.oidc.tenant-https.authentication.cookie-same-site=lax
110+
quarkus.oidc.tenant-https.authentication.cookie-same-site=strict
111111

112112
quarkus.oidc.tenant-javascript.auth-server-url=${quarkus.oidc.auth-server-url}
113113
quarkus.oidc.tenant-javascript.client-id=quarkus-app

integration-tests/oidc-code-flow/src/test/java/io/quarkus/it/keycloak/CodeFlowTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public void testCodeFlowNoConsent() throws IOException {
9595

9696
Cookie sessionCookie = getSessionCookie(webClient, null);
9797
assertNotNull(sessionCookie);
98-
assertEquals("strict", sessionCookie.getSameSite());
98+
assertEquals("lax", sessionCookie.getSameSite());
9999

100100
webClient.getCookieManager().clearCookies();
101101
}
@@ -220,7 +220,7 @@ public void testCodeFlowForceHttpsRedirectUriAndPkce() throws Exception {
220220
assertEquals("tenant-https:reauthenticated", page.getBody().asNormalizedText());
221221
Cookie sessionCookie = getSessionCookie(webClient, "tenant-https_test");
222222
assertNotNull(sessionCookie);
223-
assertEquals("lax", sessionCookie.getSameSite());
223+
assertEquals("strict", sessionCookie.getSameSite());
224224
webClient.getCookieManager().clearCookies();
225225
}
226226
}

0 commit comments

Comments
 (0)