Merge pull request #32603 from Sgitario/32383

Avoid calling after construct callbacks twice when using @nested tests

Author: geoand

integration-tests/injectmock/src/test/java/io/quarkus/it/mockbean/WithSpiesTest.java

@@ -6,6 +6,7 @@
 import jakarta.inject.Named;
 
 import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 import org.mockito.Mockito;
 
@@ -80,4 +81,20 @@ public void testOverrideDummy() {
                 .statusCode(200)
                 .body(is("1/2"));
     }
+
+    @Nested
+    class WithNested {
+        @Test
+        @DisplayName("Verify default Greeting values are returned from Spied objects")
+        public void testGreet() {
+            given()
+                    .when().get("/greeting")
+                    .then()
+                    .statusCode(200)
+                    .body(is("HELLO"));
+            Mockito.verify(capitalizerService, Mockito.times(1)).capitalize(Mockito.eq("hello"));
+            Mockito.verify(messageService, Mockito.times(1)).getMessage();
+            Mockito.verify(suffixService, Mockito.times(1)).getSuffix();
+        }
+    }
 }

test-framework/junit5/src/main/java/io/quarkus/test/junit/QuarkusTestExtension.java

@@ -765,9 +765,6 @@ private void initTestState(ExtensionContext extensionContext, QuarkusTestExtensi
             }
 
             invokeAfterConstructCallbacks(Object.class, actualTestInstance);
-            for (Object outerInstance : outerInstances) {
-                invokeAfterConstructCallbacks(Object.class, outerInstance);
-            }
         } catch (Exception e) {
             throw new TestInstantiationException("Failed to create test instance",
                     e instanceof InvocationTargetException ? e.getCause() : e);