Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pact tests work in dev mode #29

Merged
merged 5 commits into from
Dec 8, 2022

Conversation

holly-cummins
Copy link
Contributor

Resolves #11

This PR does the following:

  • Enable the integration tests, which had been failing
  • Use filtered versions rather than hardcoded versions in the integration project pom
  • Add a dummy test to help problem diagnosis in the integration tests
  • Make the integration tests work, by …
  • Setting the scope of the extension dependency to not-test; this isn’t great, but may be hard to fix.
  • Making pact work in dev mode

The changes to make pact work in dev mode are

  • Add the quarkus kotlin extension as a dependency to the extension
  • Set a bunch of libraries used by pact to be parent first, to work around NoClassDefFoundError issues. I’m a bit concerned about the implications of this change, since parent-firstness tends to spread virally through a codebase via transitive dependencies. However, I also don’t see an alternative.

@holly-cummins
Copy link
Contributor Author

When running with a version of Quarkus with quarkusio/quarkus#29697 the changes in this PR will be counter-productive, and a different set of changes will be needed. However, since that change is unlikely to be released in the 2.x branch, merging this.

@holly-cummins holly-cummins merged commit 6a5c68d into quarkiverse:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pact provider tests do not work correctly in dev mode
1 participant