Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to enable security in devmode #619

Open
maxandersen opened this issue May 24, 2024 · 4 comments · May be fixed by #659
Open

allow to enable security in devmode #619

maxandersen opened this issue May 24, 2024 · 4 comments · May be fixed by #659
Assignees

Comments

@maxandersen
Copy link
Member

with ngrok security checks should still work -but for now security is always disabled.

related to #610

@gsmet
Copy link
Member

gsmet commented May 25, 2024

How do you configure things for ngrok exactly?

@maxandersen
Copy link
Member Author

See https://docs.quarkiverse.io/quarkus-ngrok/dev/index.html until and including stable url.

I also use the next step so I don't have to the domain step in every app but is not required.

So in short:

Add ngrok ext.
Get auth token and set it (.token)
Get stable domain url and set it (.domain)

Run in Quarkus dev.

@gsmet gsmet self-assigned this Aug 20, 2024
@gsmet
Copy link
Member

gsmet commented Aug 23, 2024

Apparently smee.io can also push the rawdata now so we could probably enable security now: probot/smee.io@8c33d74

gsmet added a commit to gsmet/quarkus-github-app that referenced this issue Aug 23, 2024
gsmet added a commit to gsmet/quarkus-github-app that referenced this issue Aug 23, 2024
@gsmet gsmet linked a pull request Aug 23, 2024 that will close this issue
@gsmet
Copy link
Member

gsmet commented Aug 23, 2024

Did some work here but still pending some smee.io changes: #659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants