Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a better property name to specify the authzed image to use in the DevService #33

Open
iocanel opened this issue Nov 11, 2022 · 1 comment
Open

Use a better property name to specify the authzed image to use in the DevService #33

iocanel opened this issue Nov 11, 2022 · 1 comment

Comments

@iocanel
Copy link
Contributor

iocanel commented Nov 11, 2022

The property imageName is a somehow confusing as does not make it clear if it can include things like registry, tag etc.

A better name would be just image.

Given that we are currently at 0.0.x which implies that our public interfaces are volatile we can proceed with this change without deprecating imageName first.
@kdubb
Copy link
Contributor

kdubb commented Aug 22, 2024

imageName is used by nearly everyy dev service. Is this really something that we need to deviate from the norm for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iocanel @kdubb