Bad version labeling for released package

[jsmidt]

Problem Description

If I install the latest release of alphalens:

wget https://github.com/quantopian/alphalens/archive/0.4.0.tar.gz
tar -xf 0.4.0.tar.gz
cd alphalens-0.4.0
python setup.py build
sudo python setup.py install

Then look at the version number

python
import alphalens
print (alphalens.__version__)

I get: 0+unknown

Furthermore checking the actual install:

ls /usr/lib/python3.8/site-packages/alphalens-*

Gives: /usr/lib/python3.8/site-packages/alphalens-0+unknown-py3.8.egg

In both cases the version number shows "0+unknown" instead of "0.4.0". This will be a problem if for any reason a python package depends on version 0.4.0 or greater.

Versions

• Alphalens version: 0.4.0
• Python version: 3.8.2

[eigenfoo]

Alphalens uses versioneer to pull release tags from git tags. Right now it's set up to expect a git tag v0.4.0, but the latest tag is just 0.4.0. Could that be it?

cc @richafrank @dmichalowicz

[dmichalowicz]

The missing v appeared to be the problem, I just pushed a new tag. @jsmidt mind trying it out again?

[jsmidt]

Yes, this resolved the problem:

ls /usr/lib/python3.8/site-packages/alphalens-*
/usr/lib/python3.8/site-packages/alphalens-0.4.0-py3.8.egg

Thanks!