Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard ids hashing leads to unexpected UX #61

Open
berekuk opened this issue Apr 18, 2022 · 1 comment
Open

Dashboard ids hashing leads to unexpected UX #61

berekuk opened this issue Apr 18, 2022 · 1 comment
Labels
question Further information is requested

Comments

@berekuk
Copy link
Collaborator

berekuk commented Apr 18, 2022

If I go to https://metaforecast.org/dashboards and create a dashboard with example ids but a modified title, I'll get someone else's dashboard (e.g., the default one), because INSERT in pgInsertIntoDashboard fails quietly and dashboard id is built from question ids only.

Is this a feature or a bug? Seems more like a bug to me, but I'm not entirely sure.

Maybe we should switch to the random uuids/cuids instead of relying on hashing?

@berekuk berekuk added the question Further information is requested label Apr 18, 2022
@berekuk berekuk changed the title Dashboard ids hashing is strange Dashboard ids hashing causes strange behavior Apr 18, 2022
@berekuk berekuk changed the title Dashboard ids hashing causes strange behavior Dashboard ids hashing causes leads to unexpected UX Apr 18, 2022
@berekuk berekuk changed the title Dashboard ids hashing causes leads to unexpected UX Dashboard ids hashing leads to unexpected UX Apr 18, 2022
@NunoSempere
Copy link
Collaborator

Yeah, this was a badly thought out feature, is fine to change. I'd have a weak preference for SHA-hashing the whole object, rather than just the array of ids

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants