[BLOG] Add Making pygments accessible #527
Conversation
isabela-pf
added
labs 🔭
isabela-pf
requested review from
noatamir,
trallard and
rgommers
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This doesn't seem to be the case. The gifs here flash between the light and dark themes. Why not just show all the themes as multiple images? |
We could do any of them, I'm not sure which one will look better 😅 |
|
Thanks for the feedback, @asmeurer! I've changed the blog images from animations to static images per request. While they weren't changing at high enough frames per second to meet the usual cut off for a dangerous flashing gif, I can see how the switch between light and dark mode could still be unpleasant. |
Co-authored-by: Tania Allard <[email protected]>
|
Hi again! I think I've addressed all the feedback listed above and moved the post date out to November 7. Please let me know if there's anything else you'd like me to address. Thank you! |
|
Even ignoring the flashing concern, I prefer the style now used here because it makes it easier to compare the themes side-by-side. |
|
I have a few high-level comments relating to the post. I know this is somewhat close to the posting deadline, so feel free to not address these if it's too much work (although I am curious about the answers for my own edification regardless).
Also, it looks like the vercel build failed because of some YAML issue in the post metadata. |
| @@ -0,0 +1,70 @@ | |||
| --- | |||
| title: '"Let's make Pygments accessible!"' | |||
There was a problem hiding this comment.
| title: '"Let's make Pygments accessible!"' | |
| title: "Let's make Pygments accessible!" |
There was a problem hiding this comment.
I think the single quotes might be the issue here. Because of the apostrophe inside the Let's
There was a problem hiding this comment.
It was with single quotes before so will need inspecting closer
There was a problem hiding this comment.
Sorry, poorly phrased! I meant double as in double within single. two times the quotes needed.
There was a problem hiding this comment.
The author slug is correct. I checked that before commenting. This is what made me investigate the row above to begin with.
There was a problem hiding this comment.
Yup we have tried few combos of the quotes.
@isabela-pf and @steff456 since it has been too much faff debugging this what about changing the title to "Making pygments accessible" 🙏🏽 ? At least to avoid delaying this once more
| @@ -0,0 +1,70 @@ | |||
| --- | |||
| title: '"Let's make Pygments accessible!"' | |||
There was a problem hiding this comment.
Yup we have tried few combos of the quotes.
@isabela-pf and @steff456 since it has been too much faff debugging this what about changing the title to "Making pygments accessible" 🙏🏽 ? At least to avoid delaying this once more
steff456
changed the title
|
This is finally building and the content has been reviewed multiple times. Merging now 🚀 |
Text styling
Non-text contents
This blog was requested by @trallard and written by @steff456 and myself. It announces Stephannie's work to make Pygments versions of existing accessible syntax highlighting themes and invites readers to try out the package.
This is my first time adding a blog post to the new website, so please let me know if I made a mistake so I can learn for the future. Thanks in advance for any feedback! 🌻