QQuickOverlay: Handle hover events

With recent changes to hover handling logic, hover events would have
been sent to the "main window", even if a popup were modal. As this is
unwanted (a modally blocked button should not auto-raise when hovered),
we now prevent delivery of those events in QQuickOverlay and
overlayEvent.
The logic is the same as for mouse and touch events: If we get a
matching event, we ask the popup to handle it. The popup then uses the
existing blockInput logic to decide whether the event should be blocked
or forwarded.

Pick-to: 6.2
Change-Id: I2194fd8e832592efd5b7b9697412bdaeaea74b83
Reviewed-by: Shawn Rutledge <[email protected]>
Reviewed-by: Andrei Golubev <[email protected]>

Author: Inkane

src/quicktemplates2/qquickoverlay.cpp

@@ -207,6 +207,22 @@ bool QQuickOverlayPrivate::handleMouseEvent(QQuickItem *source, QMouseEvent *eve
     return false;
 }
 
+bool QQuickOverlayPrivate::handleHoverEvent(QQuickItem *source, QHoverEvent *event, QQuickPopup *target)
+{
+    switch (event->type()) {
+    case QEvent::HoverEnter:
+    case QEvent::HoverMove:
+    case QEvent::HoverLeave:
+        if (target)
+            return target->overlayEvent(source, event);
+        return false;
+    default:
+        Q_UNREACHABLE(); // function must only be called on hover events
+        break;
+    }
+    return false;
+}
+
 #if QT_CONFIG(quicktemplates2_multitouch)
 bool QQuickOverlayPrivate::handleTouchEvent(QQuickItem *source, QTouchEvent *event, QQuickPopup *target)
 {
@@ -474,6 +490,10 @@ bool QQuickOverlay::childMouseEventFilter(QQuickItem *item, QEvent *event)
             case QEvent::TouchEnd:
                 return d->handleTouchEvent(item, static_cast<QTouchEvent *>(event), popup);
 #endif
+            case QEvent::HoverEnter:
+            case QEvent::HoverMove:
+            case QEvent::HoverLeave:
+                return d->handleHoverEvent(item, static_cast<QHoverEvent *>(event), popup);
 
             case QEvent::MouseButtonPress:
             case QEvent::MouseMove:

src/quicktemplates2/qquickoverlay_p_p.h

@@ -74,6 +74,7 @@ class QQuickOverlayPrivate : public QQuickItemPrivate, public QQuickItemChangeLi
     bool handleRelease(QQuickItem *source, QEvent *event, QQuickPopup *target);
 
     bool handleMouseEvent(QQuickItem *source, QMouseEvent *event, QQuickPopup *target = nullptr);
+    bool handleHoverEvent(QQuickItem *source, QHoverEvent *event, QQuickPopup *target = nullptr);
 #if QT_CONFIG(quicktemplates2_multitouch)
     bool handleTouchEvent(QQuickItem *source, QTouchEvent *event, QQuickPopup *target = nullptr);
 #endif

src/quicktemplates2/qquickpopup.cpp

@@ -412,6 +412,19 @@ bool QQuickPopupPrivate::handleMouseEvent(QQuickItem *item, QMouseEvent *event)
     }
 }
 
+bool QQuickPopupPrivate::handleHoverEvent(QQuickItem *item, QHoverEvent *event)
+{
+    switch (event->type()) {
+    case QEvent::HoverEnter:
+    case QEvent::HoverMove:
+    case QEvent::HoverLeave:
+        return blockInput(item, event->scenePosition());
+    default:
+        Q_UNREACHABLE();
+        return false;
+    }
+}
+
 #if QT_CONFIG(quicktemplates2_multitouch)
 bool QQuickPopupPrivate::handleTouchEvent(QQuickItem *item, QTouchEvent *event)
 {
@@ -2558,6 +2571,10 @@ bool QQuickPopup::overlayEvent(QQuickItem *item, QEvent *event)
     case QEvent::TouchEnd:
         return d->handleTouchEvent(item, static_cast<QTouchEvent *>(event));
 #endif
+    case QEvent::HoverEnter:
+    case QEvent::HoverMove:
+    case QEvent::HoverLeave:
+        return d->handleHoverEvent(item, static_cast<QHoverEvent *>(event));
 
     case QEvent::MouseButtonPress:
     case QEvent::MouseButtonRelease:

src/quicktemplates2/qquickpopup_p_p.h

@@ -120,6 +120,7 @@ class Q_QUICKTEMPLATES2_PRIVATE_EXPORT QQuickPopupPrivate
     virtual void handleUngrab();
 
     bool handleMouseEvent(QQuickItem *item, QMouseEvent *event);
+    bool handleHoverEvent(QQuickItem *item, QHoverEvent *event);
 #if QT_CONFIG(quicktemplates2_multitouch)
     bool handleTouchEvent(QQuickItem *item, QTouchEvent *event);
 #endif