-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Lambda unhandled exception #824
Comments
AWS lambda was added as a contribution by the community: We personally are not working with AWS LAMBDA, and are limited in our ability to support specific problems people encounter. I am not sure if its related to PR-Agent code, or the deployment. probably the latter It's weird you see a "no module named fastapi" error, since its in a Maybe try asking people who have worked with AWS LAMBDA with PR-Agent @koid were you able to deploy to AWS Lambda ? |
@mrT23 see my PR ☝️ Edit: the follow up problem was also related to the docker image created for Lambda, as it was missing git |
After resolving the Lambda issues I finally ran some tests. I'e tried to add a "/review" comment and to open a PR. |
@s1moe2 I don't think this is something that comes from PR-Agent definitions |
Ah yes, my bad. I had not changed the default timeout. Thanks. |
@s1moe2 How did you handle putting the github__private_key in the lambda environment variables. I've tried multiple ways of setting multi line strings and such but they all result in errors. |
@taimaruuu No idea how you are deploying. In my case, I am using OpenTofu, so I'm reading the content of a file using its features:
I believe you should be able to also set the string directly by using \n characters. |
@s1moe2 I was having issues with it and tried multiple ways of doing it with \n, \n and more. Eventually settled for just storing the private key as a base64 encoded string in the variables and then adding code to decode it before using it for authentication |
Followed documentation to deploy PR Agent on AWS Lambda, to use in a github app.
When github tests with a ping request the response is a 502. Tried to use the app in the configured repo but it's not even making a request, I assume because the app is not in a ready state.
In CloudWatch I see logs related to the request, noticeably this warning:
I've tried a few things related to env vars, as I was not sure it could be the problem, but I noticed no difference in any approach I tried.
The text was updated successfully, but these errors were encountered: