-
-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The currently supported 68keys board is a duplicate of the mf68 #4391
Comments
It may be, but it's different people doing it. I'd feel better about leaving them as separate boards. |
How does the original author, @sbstjn feel about the proposed suggestion? So to play play devil's advocate briefly, If myself and 8 others were to purchase Planck pcbs and port new boards under the usual location....
there would effectively be 10 boards the same, wouldn't this lean towards a less maintainable code base? |
Because in this case, it may not be the same PCB. And in that case, we do have something like tht already with the planck, contra, fractal, and the like. |
From the site i linked, I have to say, Its a shame to hear that this awesome project advocates for code duplication. |
Ah, okay, it is the same PCB then. In that case, yeah, don't need multiple boards. So, it's not that we advocate for code duplication, it's more that I didn't want to step on somebody's foot, in case it wasn't actually the same PCB. |
Cheers @drashna. Thanks for hearing me out on this one. |
The currently supported 68keys board is a duplicate of the mf68. According to the docs, the site details the process of getting the mf68 gerber files printed without any modifications.
Suggestion: merge keyboard folders together, adding the existing 68keys default keymap to mf68/keymaps/68keys
The text was updated successfully, but these errors were encountered: