Skip to content

Commit 627e35b

Browse files
authored
Remove Nixpkgs-provided poetry from the environment (#17673)
The `poetry` package from the used Nixpkgs snapshot triggers the regex compatibility issue in Nix >= 2.10.0 binaries for `x86_64-darwin`: https://www.github.com/NixOS/nix/issues/4758 Remove the `poetry` package from the Nix shell environment for now (it is not really required to compile QMK, only to develop the Nix shell environment itself). In addition, all `poetry` version earlier than 1.1.14 became effectively non-functional after a breaking change of the PyPI JSON API: https://www.github.com/python-poetry/poetry/pull/5973 Updating the `poetry` package is not trivial (just adding it it to `pyproject.toml` does not work due to dependency version conflicts with other modules), therefore removing it seems to be the easiest solution to restore compatibility with new Nix versions while not creating any major inconvenience for QMK users.
1 parent c10d0fc commit 627e35b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: shell.nix

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ in
4848
mkShell {
4949
name = "qmk-firmware";
5050

51-
buildInputs = [ clang-tools dfu-programmer dfu-util diffutils git pythonEnv poetry niv ]
51+
buildInputs = [ clang-tools dfu-programmer dfu-util diffutils git pythonEnv niv ]
5252
++ lib.optional avr [
5353
pkgsCross.avr.buildPackages.binutils
5454
pkgsCross.avr.buildPackages.gcc8

0 commit comments

Comments
 (0)