Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangerous function call #51

Open
djo-it opened this issue Jan 2, 2020 · 0 comments
Open

Dangerous function call #51

djo-it opened this issue Jan 2, 2020 · 0 comments

Comments

@djo-it
Copy link

djo-it commented Jan 2, 2020

Hi,

I've found some little issues in your example code. At

header.ParseFromString(header_iterator->second.data());

and

header.ParseFromString(header_iterator->second.data());

In this case it would be more safe to use the ParseFromArray function because the data can contain zero bytes which will result in a parse error. This caused some problems in our sse because we are evaluating the metadata.

Kind regards,
Daniel John

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant