feat: add @role for elements #190
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AcesAndEights
changed the title
added 6 commits
August 6, 2019 10:54
AcesAndEights
changed the title
dimonka83
changed the title
# Conflicts: # packages/desktop/src/list/List.tsx # packages/mobile/src/list/List.tsx
dimonka83
requested changes
Sep 17, 2019
dimonka83
requested changes
Sep 19, 2019
| @@ -13,6 +13,8 @@ export interface BlockProps { | |||
|
|
|||
| export const Block: FC<BlockProps> = (props) => ( | |||
| <Card | |||
| role="section" | |||
| aria-label="block" | |||
There was a problem hiding this comment.
Атрибут aria-label создаёт текстовую метку текущего элемента в случае отсутствия видимого текста описания элемента. зачем тут просто block всегда?
| @@ -23,7 +23,7 @@ export const Grid: FC<GridProps> = ({gutter = 20, columns = 12, layout = columns | |||
| const rowBlocksCount: number = columns / layoutSum * layoutLength | |||
|
|
|||
| return ( | |||
| <Flex wrap="wrap"> | |||
| <Flex wrap="wrap" role="section" aria-label="grid"> | |||
There was a problem hiding this comment.
есть роль grid и опять label один для всех и не понятно зачем он тут
| @@ -200,7 +200,7 @@ export const Icon: FC<IconProps> = ({ | |||
| size = 6, | |||
| color = '#000', | |||
| }) => ( | |||
| <Svg width={size} height={size} viewBox="0 0 24 24" focusable="false"> | |||
| <Svg width={size} height={size} viewBox="0 0 24 24" focusable="false" role="img" alt={name}> | |||
There was a problem hiding this comment.
как я понял тут aria-label нужен, а не alt
| @@ -54,6 +54,7 @@ export const BasicInput: FunctionComponent<BasicInputProps> = (props) => { | |||
| onBlur: props.onBlur, | |||
| onKeyDown: props.onKeyDown, | |||
| onKeyUp: props.onKeyUp, | |||
| role: 'textbox', | |||
| @@ -7,6 +7,7 @@ export interface LinkControlProps { | |||
| onFocus?: () => void | |||
| onBlur?: () => void | |||
| href?: string | |||
| title?: string | |||
| @@ -9,6 +9,7 @@ interface SvgProps { | |||
| transition?: string | |||
| transform?: string | |||
| transformOrigin?: string | |||
| alt?: string | |||
There was a problem hiding this comment.
как выше писал, возможно aria-label, а не alt
| @@ -27,6 +27,7 @@ const BlockAccordionIndent: { | |||
|
|
|||
| export const BlockAccordion: FunctionComponent<BlockAccordionProps<BlockAccordionItemModel>> = ({items, indent = 'm', tabIndex = 0, opened, onChange}) => ( | |||
| <AccordionControl<BlockAccordionItemModel> | |||
|
|
|||
| @@ -45,6 +45,7 @@ const TextColor: { [color in NonNullable<TextProps['color']>]: string } = { | |||
| export const Text: FunctionComponent<TextProps> = ({display, compact, size, bold, color, decoration, transform, transition, align, clamp, children}) => ( | |||
| <Typo | |||
| as="span" | |||
| role="textbox" | |||
There was a problem hiding this comment.
зачем у текста textbox?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил role для