Remove constraint on numpy version from tox.ini#1320
Merged
Conversation
Collaborator
Author
|
The motivation for this constraint was mostly removed in Qiskit main (Qiskit/qiskit#11020 and earlier) and might be addressed enough for the experiments tests at least. Maybe we want to wait and watch Qiskit/qiskit#11232 before merging this, but I thought we could at least have it open as a reminder. |
coruscating
approved these changes
Nov 29, 2023
Collaborator
coruscating
left a comment
coruscating
left a comment
There was a problem hiding this comment.
This seems safe to merge, thanks. Do you want to add a short description for the PR?
itoko
pushed a commit
to itoko/qiskit-experiments
that referenced
this pull request
Dec 12, 2023
numpy 1.25 had deprecated some functions used by Qiskit. Since the tests are set to fail if deprecation warnings are emitted, the numpy version was pinned while Qiskit worked on addressing the deprecated usage. Now that Qiskit has addressed these issues, the version constraint can be removed. Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>
nkanazawa1989
pushed a commit
to nkanazawa1989/qiskit-experiments
that referenced
this pull request
Jan 17, 2024
numpy 1.25 had deprecated some functions used by Qiskit. Since the tests are set to fail if deprecation warnings are emitted, the numpy version was pinned while Qiskit worked on addressing the deprecated usage. Now that Qiskit has addressed these issues, the version constraint can be removed. Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numpy 1.25 had deprecated some functions used by Qiskit. Since the tests are set to fail if deprecation warnings are emitted, the numpy version was pinned while Qiskit worked on addressing the deprecated usage. Now that Qiskit has addressed these issues, the version constraint can be removed.