This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Remove gates that moved to Terra#833
Merged
woodsp-ibm merged 4 commits intoFeb 26, 2020
Merged
Conversation
…emove-duplicate-gates
…ua into remove-duplicate-gates
woodsp-ibm
approved these changes
Feb 26, 2020
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
…ve-duplicate-gates Remove gates that moved to Terra
manoelmarques
pushed a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 7, 2020
…ve-duplicate-gates Remove gates that moved to Terra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The following gates have moved to Terra
and should be removed from Aqua.
Details and comments
In the case of the relative-phase Toffolis (
rcc(c)x) the Aqua-version does not support integer indices as qubit arguments which causes Terra tests to fail, if both Aqua and Terra are available locally (Qiskit/qiskit#3863).As these gates are being converted to
Gatetypes instead of functions (e.g. Qiskit/qiskit#3761 and Qiskit/qiskit#3886) we need to remove them from Aqua since otherwise the definition of Terra will be overwritten.