From 74c756edea728ffa81e3786b30e8d0153ffcc37c Mon Sep 17 00:00:00 2001 From: tellet-q Date: Mon, 14 Apr 2025 13:17:37 +0200 Subject: [PATCH 1/2] Fix descriptions --- .github/workflows/manual-compare-versions-benchmark.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/manual-compare-versions-benchmark.yaml b/.github/workflows/manual-compare-versions-benchmark.yaml index 025a3ef4..c658b98a 100644 --- a/.github/workflows/manual-compare-versions-benchmark.yaml +++ b/.github/workflows/manual-compare-versions-benchmark.yaml @@ -8,10 +8,10 @@ on: workflow_dispatch: inputs: qdrant_version_1: - description: "Version of qdrant to benchmark (ghcr/, ghcr/my-branch, docker/v1.5.1, ghcr/dev)" + description: "Version of qdrant to benchmark (ghcr/, ghcr/my-branch, docker/v1.5.1, ghcr/dev), version 1" default: ghcr/dev qdrant_version_2: - description: "Version of qdrant to benchmark (ghcr/, ghcr/my-branch, docker/v1.5.1, ghcr/dev)" + description: "Version of qdrant to benchmark (ghcr/, ghcr/my-branch, docker/v1.5.1, ghcr/dev), version 2" default: docker/master dataset: description: "Dataset to benchmark" @@ -20,10 +20,10 @@ on: description: "Engine config to benchmark" default: qdrant-continuous-benchmark feature_flags_all_version_1: - description: "Enable all feature flags (true|false, false by default)" + description: "Enable all feature flags (true|false, false by default) for version 1" default: false feature_flags_all_version_2: - description: "Enable all feature flags (true|false, false by default)" + description: "Enable all feature flags (true|false, false by default) version 2" default: false jobs: From 1fe9d865c1bff806504cc2156d9974f857484793 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20Vis=C3=A9e?= Date: Mon, 14 Apr 2025 13:54:53 +0200 Subject: [PATCH 2/2] Apply suggestions from code review --- .github/workflows/manual-compare-versions-benchmark.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/manual-compare-versions-benchmark.yaml b/.github/workflows/manual-compare-versions-benchmark.yaml index c658b98a..fb1e486a 100644 --- a/.github/workflows/manual-compare-versions-benchmark.yaml +++ b/.github/workflows/manual-compare-versions-benchmark.yaml @@ -20,10 +20,10 @@ on: description: "Engine config to benchmark" default: qdrant-continuous-benchmark feature_flags_all_version_1: - description: "Enable all feature flags (true|false, false by default) for version 1" + description: "Enable all feature flags (true|false, false by default), version 1" default: false feature_flags_all_version_2: - description: "Enable all feature flags (true|false, false by default) version 2" + description: "Enable all feature flags (true|false, false by default), version 2" default: false jobs: