Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is grpcio-tools a necessary non-dev dependency? #879

Open
tjni opened this issue Jan 12, 2025 · 5 comments
Open

Is grpcio-tools a necessary non-dev dependency? #879

tjni opened this issue Jan 12, 2025 · 5 comments

Comments

@tjni
Copy link

tjni commented Jan 12, 2025

Hello!

I noticed that grpcio-tools is listed as both a dev and non-dev dependency. Is it needed in non-dev? (If not, I'd like to remove it from the dependency tree and can submit a PR.)

@generall
Copy link
Member

generall commented Jan 12, 2025

it is necessary

we need to check

@tjni
Copy link
Author

tjni commented Jan 13, 2025

Thank you for the consideration! On disk, the shared object that it brings in is quite large, hence why I noticed it.

@jizhilong
Copy link

On disk, the shared object that it brings in is quite large, hence why I noticed it.

and for legacy systems with no grpcio-tools.whl nor C build toolchains, this dependency will break the installation of qdrant-client.

@tjni
Copy link
Author

tjni commented Jan 24, 2025

Hi @generall, have you had any time to check?

@joein
Copy link
Member

joein commented Jan 30, 2025

hey @tjni

grpcio-tools is not a required non-dev dependency, but protobuf is
we'll try to replace grpcio-tools with just protobuf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants