Skip to content

Commit 5fda321

Browse files
author
Amr Essam
committed
Add pagination comment
1 parent e1140fa commit 5fda321

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

internal/provider/providers/vultr/getrecord.go

+4
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ func (p *Provider) getRecord(ctx context.Context, client *http.Client) (r Record
1818
Host: "api.vultr.com",
1919
Path: fmt.Sprintf("/v2/domains/%s/records", p.domain),
2020
}
21+
22+
// max return of get records is 500 records
2123
values := url.Values{}
2224
values.Set("per_page", "500")
2325
u.RawQuery = values.Encode()
@@ -35,6 +37,8 @@ func (p *Provider) getRecord(ctx context.Context, client *http.Client) (r Record
3537
defer response.Body.Close()
3638

3739
decoder := json.NewDecoder(response.Body)
40+
41+
// todo: implement pagination
3842
var parsedJSON struct {
3943
Error string
4044
Status uint32

0 commit comments

Comments
 (0)