Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide way to configure torrent parsing limits, since some torernts will fail to load with default limits #12029

Closed
FranciscoPombal opened this issue Feb 18, 2020 · 3 comments
Labels
Confirmed bug An issue confirmed by project team to be considered as a bug Core Feature request

Comments

@FranciscoPombal
Copy link
Member

FranciscoPombal commented Feb 18, 2020

qBittorrent version and Operating System

Latest master, any OS.

If on linux, libtorrent-rasterbar and Qt version

N/A

What is the problem

Certain torrents cannot be loaded due to the limits qBittorrent uses:
#10913 This can now be loaded because the default limits in libtorrent have been raised since. Example of a torrent that still can't be loaded with the new defaults: #10913 (comment)

What is the expected behavior

It would be nice if qBittorrent provided a way to configure the limits, so that when a user encounters such a torrent, they can go to the settings and increase the limits a bit so that the torrent can be loaded.

It would be even nicer if qBittorrent dynamically prompted the user upon such an error, e.g. a popup dialog asking "Looks like the torrent is too big to be parsed. Try again with increased limits? ( -> )". If it fails, direct the users to the appropriate setting to try to manually input big enough limits.

Steps to reproduce

Load the torrent Tutorials.torrent (~60 MiB) linked in #10913 (comment), or other similarly large torrent that exceeds the default torrent loading parameters in libtorrent.

Extra info(if any)

Current hardcoded limits can simply be increased, but IMO that is not a complete and proper solution.

@FranciscoPombal FranciscoPombal added the Confirmed bug An issue confirmed by project team to be considered as a bug label Oct 23, 2020
@FranciscoPombal FranciscoPombal changed the title Provide way to configure torrent parsing limits Provide way to configure torrent parsing limits, since some torernts will fail to load with default limits Oct 23, 2020
@jasonsyoung
Copy link

I'll just leave this here. I had worked on adding to the interface the needed configuration for setting the number of pieces for a torrent, and others for allowing large torrents to be added to qBitorrent. I was never able to get this completely working as I am not well-versed in this codebase or C++, so most of it worked, but the values were not being persisted. My branch now is far behind master and I am having trouble comparing it to see my changes on the commit I made. It's pretty close to being done, but I am not sure if it is relevant anymore. I'll leave my fork, branch, and code on my account for any dev interested: https://github.com/jasonsyoung/qBittorrent/tree/load_torrent_limits . If it is of no use, please let me know and I will delete it.

@MysticRyuujin

This comment has been minimized.

@ghost
Copy link

ghost commented May 5, 2022

Limits were bumped recently in libtorrent so should be fixed in next release.

@ghost ghost closed this as completed May 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed bug An issue confirmed by project team to be considered as a bug Core Feature request
Projects
None yet
Development

No branches or pull requests

3 participants