Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability : Arbitrary Access Through CORS Misconfiguration #337

Open
sgwgsw opened this issue Jan 9, 2024 · 0 comments
Open

Vulnerability : Arbitrary Access Through CORS Misconfiguration #337

sgwgsw opened this issue Jan 9, 2024 · 0 comments

Comments

@sgwgsw
Copy link

sgwgsw commented Jan 9, 2024

https://github.com/q191201771/lal/blob/92252c8b91004301b13e353063a1a9f1a362969a/pkg/base/cors.go#L13C1-L17

"Access-Control-Allow-Origin: *" Is set, granting any domain access to CORS resources. There should be a white-list in the configuration that lists allowed Origin headers.

The issue is made worse with "Access-Control-Allow-Credentials: true". Now that any domain can access the endpoints, they also can also authenticate as another user. This can be done by sending a crafted link to a user who is logged in (presumably, unless session token is persistent) - once clicked, the script would send a CORS request to sensitive endpoints and the browser would send along their cookies since "Access-Control-Allow-Credentials: true" is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants