Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification on start/stop pull HLS? #152

Closed
nilopaim opened this issue Apr 25, 2022 · 6 comments
Closed

Notification on start/stop pull HLS? #152

nilopaim opened this issue Apr 25, 2022 · 6 comments

Comments

@nilopaim
Copy link

Is there some way of receiving a notification when someone starts/stops to receive HLS stream?

@q191201771
Copy link
Owner

Currently no notification for HLS.
I will add these notifications, but after I finished my recent job.

@nilopaim
Copy link
Author

Thanks for your prompt response.

Can you guide me about the points on the code where I could try to implement something? I can submit a PR if I succeded in this...

By the way, nice software! Really nice! Congrats!

@q191201771
Copy link
Owner

https://github.com/q191201771/lal/blob/master/pkg/logic/server_manager.go#L848
https://github.com/q191201771/lal/blob/master/pkg/hls/server_handler.go

You can start with these codes around.

It's very nice that you are wishing to send PR, but since I would refactor the whole HTTP Notify module when adding HLS notifications, PR may conflict a lot and not be accepted.
Maybe watching the repo continuity and helping us in the feature.

@nilopaim
Copy link
Author

I'll be watching and I'll help any way I could.

Thanks.

@q191201771
Copy link
Owner

move to #157

@q191201771
Copy link
Owner

This feature has been done, check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants