Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship torchax inside torch_xla #8831

Open
tengyifei opened this issue Mar 13, 2025 · 1 comment
Open

Ship torchax inside torch_xla #8831

tengyifei opened this issue Mar 13, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request torchxla2

Comments

@tengyifei
Copy link
Collaborator

🚀 Feature

When users install torch_xla, they would get torchax as well.

Motivation

The xb.call_jax 1 feature under heavy development uses torchax and we expect torchax usage to grow. In order for all users of torch_xla to use this feature, we need to include torchax in torch_xla wheels/dockers/etc.

Pitch

I think there are two approaches:

  1. Make torchax its own Python wheel/package, and have torch_xla depend on it always.

  2. Literally link all torchax files inside the torch_xla wheel/package. This approach might need to deal with some packaging subtleties because some users may have already installed torchax standalone and not sure what will happen when they also install torch_xla with its own torchax.

Either way, this probably requires some setup.py changes.

cc @qihqi

@tengyifei
Copy link
Collaborator Author

A big motivation is making atomic changes across torchax and torch_xla. This is only doable if torch_xla includes torchax by source. So the wheel option is probably out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request torchxla2
Projects
None yet
Development

No branches or pull requests

2 participants