Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow recipes to work without a LR scheduler #2021

Open
felipemello1 opened this issue Nov 18, 2024 · 0 comments · May be fixed by #2051
Open

Allow recipes to work without a LR scheduler #2021

felipemello1 opened this issue Nov 18, 2024 · 0 comments · May be fixed by #2051
Labels
community help wanted We would love the community's help completing this issue

Comments

@felipemello1
Copy link
Contributor

In this PR, it was implemented for one recipe: https://github.com/pytorch/torchtune/pull/1991/files

As a follow up, it should be implemented to every recipe
@felipemello1 felipemello1 added the community help wanted We would love the community's help completing this issue label Nov 18, 2024
This was referenced Nov 18, 2024
Merged
Closed
@thomasjpfan thomasjpfan linked a pull request Nov 22, 2024 that will close this issue
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community help wanted We would love the community's help completing this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not require lr_scheduler for all other recipes thomasjpfan/torchtune
1 participant
@felipemello1