Skip to content

Add logging for learning rates in MetricsProcessor #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tianyu-l merged 4 commits into from
Jul 31, 2025
Merged

Add logging for learning rates in MetricsProcessor #1413

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da9fc6a
Add logging for learning rates in MetricsProcessor
idoh Jul 18, 2025
b5e5b2f
Simplify learning rate logging to log only the first scheduler's lear…
idoh Jul 28, 2025
f37a69e
Add note to clarify learning rate logging behavior in MetricsProcessor
idoh Jul 29, 2025
69916b6
Refactor learning rate logging in MetricsProcessor and Trainer
idoh Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion torchtitan/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,8 @@ def train_step(
self, data_iterator: Iterable[tuple[dict[str, torch.Tensor], torch.Tensor]]
):
self.optimizers.zero_grad()
# Save the current step learning rate for logging
lr = self.lr_schedulers.schedulers[0].get_last_lr()[0]

# Keep these variables local to shorten the code as these are
# the major variables that are used in the training loop.
Expand Down Expand Up @@ -493,12 +495,16 @@ def train_step(
else:
global_avg_loss = global_max_loss = loss.detach().item()

extra_metrics = {
"n_tokens_seen": self.ntokens_seen,
"lr": lr,
}
self.metrics_processor.log(
self.step,
global_avg_loss,
global_max_loss,
grad_norm.item(),
extra_metrics={"ntokens_seen": self.ntokens_seen},
extra_metrics=extra_metrics,
)

@record
Expand Down
Loading