-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkpoint stateful handlers and metrics #966
Comments
@amatsukawa thanks for FR! Yes, it definitely makes sense for handlers and metrics with internal state 👍 |
FWIW, I'm completely happy with #1156 and the way things work now. With complications I didn't think about, eg. some handlers needing to go on the valid engine and handlers needing to run in a specific order ( |
🚀 Feature
Things that are attached to the
Engine
might have state that would ideally be checkpointed and restored using as part of theEngine
'sstate_dict
.An example is a
Checkpoint
handler when it has ascore_function
. Currently, the priorities theCheckpoint
class stores is not saved anywhere. It is not able to recover gracefully from failure without manual intervention to parse the checkpoint path names, and directly setting the internals of the class.Handlers and Metrics should have
state_dict
andload_state_dict
methods (empty by default), and I think it should be possible for these to automatically make it into/restored from theEngine
'sstate_dict
when it's attached to anEngine
.The text was updated successfully, but these errors were encountered: