Skip to content

Commit 9a0c2db

Browse files
authored
Split android instrumentation from build script
Differential Revision: D71161609 Pull Request resolved: #9249
1 parent 699ee7d commit 9a0c2db

File tree

3 files changed

+41
-10
lines changed

3 files changed

+41
-10
lines changed

.github/workflows/_android.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ jobs:
3030
3131
# Build LLM Demo for Android
3232
bash build/build_android_library.sh ${ARTIFACTS_DIR_NAME}
33+
bash build/build_android_instrumentation.sh
3334
3435
# Running Android emulator directly on the runner and not using Docker
3536
run-emulator:
Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
#!/bin/bash
2+
# Copyright (c) Meta Platforms, Inc. and affiliates.
3+
# All rights reserved.
4+
#
5+
# This source code is licensed under the BSD-style license found in the
6+
# LICENSE file in the root directory of this source tree.
7+
8+
set -ex
9+
10+
if [[ -z "${PYTHON_EXECUTABLE:-}" ]]; then
11+
PYTHON_EXECUTABLE=python3
12+
fi
13+
which "${PYTHON_EXECUTABLE}"
14+
15+
build_android_test() {
16+
pushd extension/android_test
17+
ANDROID_HOME="${ANDROID_SDK:-/opt/android/sdk}" ./gradlew testDebugUnitTest
18+
ANDROID_HOME="${ANDROID_SDK:-/opt/android/sdk}" ./gradlew build assembleAndroidTest
19+
popd
20+
}
21+
22+
collect_artifacts_to_be_uploaded() {
23+
ARTIFACTS_DIR_NAME="$1"
24+
# Collect Java library test
25+
JAVA_LIBRARY_TEST_DIR="${ARTIFACTS_DIR_NAME}/library_test_dir"
26+
mkdir -p "${JAVA_LIBRARY_TEST_DIR}"
27+
cp extension/android_test/build/outputs/apk/debug/*.apk "${JAVA_LIBRARY_TEST_DIR}"
28+
cp extension/android_test/build/outputs/apk/androidTest/debug/*.apk "${JAVA_LIBRARY_TEST_DIR}"
29+
}
30+
31+
main() {
32+
build_android_test
33+
if [ -n "$ARTIFACTS_DIR_NAME" ]; then
34+
collect_artifacts_to_be_uploaded ${ARTIFACTS_DIR_NAME}
35+
fi
36+
}
37+
38+
if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
39+
main "$@"
40+
fi

build/build_android_library.sh

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -149,11 +149,6 @@ build_android_demo_apps() {
149149
pushd extension/benchmark/android/benchmark
150150
ANDROID_HOME="${ANDROID_SDK:-/opt/android/sdk}" ./gradlew build assembleAndroidTest
151151
popd
152-
153-
pushd extension/android_test
154-
ANDROID_HOME="${ANDROID_SDK:-/opt/android/sdk}" ./gradlew testDebugUnitTest
155-
ANDROID_HOME="${ANDROID_SDK:-/opt/android/sdk}" ./gradlew build assembleAndroidTest
156-
popd
157152
}
158153

159154
collect_artifacts_to_be_uploaded() {
@@ -172,11 +167,6 @@ collect_artifacts_to_be_uploaded() {
172167
mkdir -p "${MINIBENCH_APP_DIR}"
173168
cp extension/benchmark/android/benchmark/app/build/outputs/apk/debug/*.apk "${MINIBENCH_APP_DIR}"
174169
cp extension/benchmark/android/benchmark/app/build/outputs/apk/androidTest/debug/*.apk "${MINIBENCH_APP_DIR}"
175-
# Collect Java library test
176-
JAVA_LIBRARY_TEST_DIR="${ARTIFACTS_DIR_NAME}/library_test_dir"
177-
mkdir -p "${JAVA_LIBRARY_TEST_DIR}"
178-
cp extension/android_test/build/outputs/apk/debug/*.apk "${JAVA_LIBRARY_TEST_DIR}"
179-
cp extension/android_test/build/outputs/apk/androidTest/debug/*.apk "${JAVA_LIBRARY_TEST_DIR}"
180170
}
181171

182172
main() {

0 commit comments

Comments
 (0)