Skip to content

Commit 2652c64

Browse files
committed
Remove workaround for ovr_config//os:iphoneos not working in OSS
Looks like this got fixed a while ago in facebook/buck2-prelude#25 . ghstack-source-id: e30ebe5 ghstack-comment-id: 3420048597 Pull-Request: #15263
1 parent 810b8e8 commit 2652c64

File tree

1 file changed

+2
-14
lines changed

1 file changed

+2
-14
lines changed

extension/threadpool/targets.bzl

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,7 @@ def define_common_targets():
4747

4848
runtime.cxx_library(
4949
name = "threadpool",
50-
# TODO: OSS doesn't have os:iphoneos. Sync buck2 prelude
51-
# update to add it and remove duplication.
52-
exported_deps = (select({
50+
exported_deps = select({
5351
# Major operating systems should be able to use threadpool.
5452
"ovr_config//os:linux": [":threadpool_lib"],
5553
"ovr_config//os:macos": [":threadpool_lib"],
@@ -60,17 +58,7 @@ def define_common_targets():
6058
"ovr_config//os:none": ["//executorch/runtime/kernel:thread_parallel_interface"],
6159
# If we don't know what it is, disable threadpool out of caution.
6260
"DEFAULT": ["//executorch/runtime/kernel:thread_parallel_interface"],
63-
}) if not runtime.is_oss else select({
64-
# Major operating systems should be able to use threadpool.
65-
"ovr_config//os:linux": [":threadpool_lib"],
66-
"ovr_config//os:macos": [":threadpool_lib"],
67-
"ovr_config//os:windows": [":threadpool_lib"],
68-
"ovr_config//os:android": [":threadpool_lib"],
69-
# Machines without an operating system shouldn't.
70-
"ovr_config//os:none": ["//executorch/runtime/kernel:thread_parallel_interface"],
71-
# If we don't know what it is, disable threadpool out of caution.
72-
"DEFAULT": ["//executorch/runtime/kernel:thread_parallel_interface"],
73-
})),
61+
}),
7462
visibility = [
7563
"//executorch/...",
7664
"@EXECUTORCH_CLIENTS",

0 commit comments

Comments
 (0)