Address more comments

Author: larryliu0820

backends/qualcomm/CMakeLists.txt

@@ -24,7 +24,8 @@ get_filename_component(
 )
 
 # We only download QNN SDK when we build pip wheel for ExecuTorch.
-if(EXECUTORCH_BUILD_WHEEL_DEV_USE_ONLY)
+# Please don't change this code unless you know what you are doing.
+if(EXECUTORCH_BUILD_WHEEL_DO_NOT_USE)
   set(_qnn_default_sdk_dir "${CMAKE_CURRENT_BINARY_DIR}/sdk/qnn")
 
   if(EXISTS "${_qnn_default_sdk_dir}" AND EXISTS "${_qnn_default_sdk_dir}/lib")

setup.py

@@ -676,8 +676,6 @@ def run(self):  # noqa C901
             # like `TorchConfig.cmake` that are provided by pip packages.
             f"-DCMAKE_PREFIX_PATH={cmake_prefix_path}",
             f"-DCMAKE_BUILD_TYPE={cmake_build_type}",
-            # Turn on the wheel building option for downstream CMakeLists.txt.
-            f"-DEXECUTORCH_BUILD_WHEEL_DEV_USE_ONLY=ON",
         ]
 
         # Use ClangCL on Windows.

tools/cmake/preset/default.cmake

@@ -289,7 +289,7 @@ define_overridable_option(
   FALSE
 )
 define_overridable_option(
-  EXECUTORCH_BUILD_WHEEL_DEV_USE_ONLY
+  EXECUTORCH_BUILD_WHEEL_DO_NOT_USE
   "On if in the wheel building process. Should only be used to guard code that is only needed for building the wheel."
   BOOL
   FALSE

tools/cmake/preset/pybind.cmake

@@ -22,6 +22,7 @@ set_overridable_option(EXECUTORCH_BUILD_EXTENSION_FLAT_TENSOR ON)
 set_overridable_option(EXECUTORCH_BUILD_EXTENSION_DATA_LOADER ON)
 set_overridable_option(EXECUTORCH_BUILD_EXTENSION_MODULE ON)
 set_overridable_option(EXECUTORCH_BUILD_EXTENSION_NAMED_DATA_MAP ON)
+set_overridable_option(EXECUTORCH_BUILD_WHEEL_DO_NOT_USE ON)
 
 # TODO(larryliu0820): Temporarily disable building llm_runner for Windows wheel
 # due to the issue of tokenizer file path length limitation.