Optimzed backward pass for ROCm devices #3367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@leitian has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @avbokovoy could you rebase this branch on latest |
avbokovoy
force-pushed
the
abokovoi/rocm-bwd-pass-optimization
branch
from
02ec7a2 to
08a71b6
Compare
Hi @q10. Sure. Done |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Nov 23, 2024
Summary: Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192]. Pull Request resolved: pytorch#3367 Differential Revision: D66310520 Pulled By: leitian
avbokovoy
force-pushed
the
abokovoi/rocm-bwd-pass-optimization
branch
from
4121411 to
8cbcdff
Compare
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Nov 25, 2024
Summary: Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192]. Pull Request resolved: pytorch#3367 Differential Revision: D66310520 Pulled By: leitian
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Nov 27, 2024
Summary: Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192]. Pull Request resolved: pytorch#3367 Differential Revision: D66310520 Pulled By: leitian
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Dec 2, 2024
Summary: Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192]. Pull Request resolved: pytorch#3367 Differential Revision: D66310520 Pulled By: leitian
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Dec 4, 2024
Summary: Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192]. Pull Request resolved: pytorch#3367 Differential Revision: D66310520 Pulled By: leitian
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Dec 5, 2024
Summary: Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192]. Pull Request resolved: pytorch#3367 Differential Revision: D66310520 Pulled By: leitian
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Dec 5, 2024
Summary: Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192]. Pull Request resolved: pytorch#3367 Differential Revision: D66310520 Pulled By: leitian
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Dec 6, 2024
Summary: X-link: facebookresearch/FBGEMM#491 Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192]. Reviewed By: leitian Differential Revision: D66310520 Pulled By: q10
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Dec 18, 2024
Summary: - Break up D66310520 (pytorch#3367) into backend and frontend diffs. This is the frontend diff, and followup to D66986498 Differential Revision: D67407935
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Dec 18, 2024
Summary: X-link: facebookresearch/FBGEMM#594 - Break up D66310520 (pytorch#3367) into backend and frontend diffs. This is the frontend diff, and followup to D66986498 Differential Revision: D67407935
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Dec 19, 2024
Summary: X-link: facebookresearch/FBGEMM#594 - Break up D66310520 (pytorch#3367) into backend and frontend diffs. This is the frontend diff, and followup to D66986498 Differential Revision: D67407935
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Dec 27, 2024
Summary: X-link: facebookresearch/FBGEMM#594 - Break up D66310520 (pytorch#3367) into backend and frontend diffs. This is the frontend diff, and followup to D66986498 Reviewed By: leitian Differential Revision: D67407935
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jan 2, 2025
Summary: X-link: facebookresearch/FBGEMM#594 - Break up D66310520 (pytorch#3367) into backend and frontend diffs. This is the frontend diff, and followup to D66986498 Reviewed By: leitian Differential Revision: D67407935
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optimized implementation of backward pass for ROCm devices. Currently support not nobag mode, rowwise_adagrad optimizer with non-mixed dimensions in [64, 128, 160, 192].