Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-95685: Fix rendering of the string documentation #95686

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

Mariatta
Copy link
Member

@Mariatta Mariatta commented Aug 4, 2022

There's an extra underlines that messed the rest of the documentation rendering.

Closes GH-95685

There's an extra underlines that messed the rest of the documentation rendering.

Closes pythonGH-95685
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting core review labels Aug 4, 2022
@Mariatta Mariatta added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Aug 4, 2022
@Mariatta
Copy link
Member Author

Mariatta commented Aug 4, 2022

I guess we meant to have just a horizontal line there, and it was conflicting with the "see also" box.

I added extra empty line to ensure that the line appears.

@ambv ambv merged commit a525f2a into python:main Aug 5, 2022
@miss-islington
Copy link
Contributor

Thanks @Mariatta for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 5, 2022
…5686)

There's an extra underlines that messed the rest of the documentation rendering.

Closes pythonGH-95685
(cherry picked from commit a525f2a)

Co-authored-by: Mariatta Wijaya <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 5, 2022
@bedevere-bot
Copy link

GH-95700 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 5, 2022
@bedevere-bot
Copy link

GH-95701 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 5, 2022
…5686)

There's an extra underlines that messed the rest of the documentation rendering.

Closes pythonGH-95685
(cherry picked from commit a525f2a)

Co-authored-by: Mariatta Wijaya <[email protected]>
ambv pushed a commit that referenced this pull request Aug 5, 2022
)

There's an extra underlines that messed the rest of the documentation rendering.

Closes #95685
(cherry picked from commit a525f2a)

Co-authored-by: Mariatta Wijaya <[email protected]>
ambv pushed a commit that referenced this pull request Aug 5, 2022
)

There's an extra underlines that messed the rest of the documentation rendering.

Closes #95685
(cherry picked from commit a525f2a)

Co-authored-by: Mariatta Wijaya <[email protected]>
@Mariatta Mariatta deleted the fix-string-doc branch August 5, 2022 19:13
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
There's an extra underlines that messed the rest of the documentation rendering.

Closes python#95685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove yellow box from string documentation
4 participants