Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44229: Intest_ssl, ignore spurious EPROTOTYPE on macOS #26893

Merged
merged 1 commit into from
Jun 24, 2021
Merged

bpo-44229: Intest_ssl, ignore spurious EPROTOTYPE on macOS #26893

merged 1 commit into from
Jun 24, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 24, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jun 24, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jun 24, 2021 •
edited
Loading

Backport though to 3.9? (...maybe even 3.8, since it's breaking CI)

@pablogsal
Copy link
Member

Backport though to 3.9? (...maybe even 3.8, since it's breaking CI)

Is the error happening on 3.9 and 3.8? I though this only happened in 3.10 and main

@pablogsal
Copy link
Member

Ok, I saw https://bugs.python.org/msg396471 :)

@erlend-aasland
Copy link
Contributor Author

I think we've just let it pass as a flakey ssl test earlier. With PEP 644, the ssl tests have been heavily scrutinised :)

@pablogsal
Copy link
Member

Also, question, in your message there are 3 different exceptions:

ConnectionResetError: [Errno 54] Connection reset by peer

 OSError: [Errno 41] Protocol wrong type for socket

ConnectionRefusedError: [Errno 61] Connection refused

are all of this fixed by this PR?

@erlend-aasland
Copy link
Contributor Author

Yes. Errno 41 always happens in the mock server set up by the test. On the client side, this results in either errno 54 or errno 61.

@pablogsal pablogsal merged commit b5a52ee into python:main Jun 24, 2021
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2021
@miss-islington
bpo-44229: Ignore spurious EPROTOTYPE on macOS in test_ssl (pythonGH-…
12ecc07 
…26893)

(cherry picked from commit b5a52ee)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 24, 2021
@bedevere-bot
Copy link

GH-26894 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2021
@miss-islington
bpo-44229: Ignore spurious EPROTOTYPE on macOS in test_ssl (pythonGH-…
5d0c1f2 
…26893)

(cherry picked from commit b5a52ee)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot
Copy link

GH-26895 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2021
@miss-islington
bpo-44229: Ignore spurious EPROTOTYPE on macOS in test_ssl (pythonGH-…
d87a47c 
…26893)

(cherry picked from commit b5a52ee)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot
Copy link

GH-26896 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 24, 2021
@erlend-aasland erlend-aasland deleted the bpo-44229 branch June 24, 2021 12:13
miss-islington added a commit that referenced this pull request Jun 24, 2021
@miss-islington
bpo-44229: Ignore spurious EPROTOTYPE on macOS in test_ssl (GH-26893)
0796e21 
(cherry picked from commit b5a52ee)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington added a commit that referenced this pull request Jun 24, 2021
@miss-islington
bpo-44229: Ignore spurious EPROTOTYPE on macOS in test_ssl (GH-26893)
b3fac29 
(cherry picked from commit b5a52ee)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
pablogsal pushed a commit that referenced this pull request Jun 24, 2021
@miss-islington
bpo-44229: Ignore spurious EPROTOTYPE on macOS in test_ssl (GH-26893) (…
71ba16b 
…GH-26895)

(cherry picked from commit b5a52ee)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
This was referenced Aug 4, 2022
Closed
Closed
@erlend-aasland erlend-aasland mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@tiran tiran Awaiting requested review from tiran

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
awaiting merge skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni