[3.12] gh-108000: Test that lambda also has __type_params__ (GH-108002)
#108019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nGH-108002) (cherry picked from commit a8d440b) Co-authored-by: Nikita Sobolev <[email protected]>
JelleZijlstra
approved these changes
Aug 16, 2023
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
I'll just merge this after 3.12.0 is out and the branch is unlocked, since I don't feel this is worth bothering Thomas about.
Member
|
It's not a bother, since it's my job. Testsuite improvements are fine at this point, if they aren't flaky/risky. We can always roll them back if they break the buildbots. Is there a reason to hold back this change? |
Member
|
No, please merge it if you don't mind. My only concern was to avoid giving you extra work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit a8d440b)
Co-authored-by: Nikita Sobolev [email protected]
lambdais not tested to have__type_params__attribute #108000