Skip to content

Commit ae147d0

Browse files
gh-104146: Purge dead code from Argument Clinic (#104680)
The following local variables were assigned but never used: - line 551: result - line 1341: groups - line 1431: default_return_converter - line 1529: ignore_self - line 1809: input_checksum - line 4224: new' --- Co-authored-by: Alex Waygood <[email protected]>
1 parent 02b6003 commit ae147d0

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

Tools/clinic/clinic.py

+1-10
Original file line numberDiff line numberDiff line change
@@ -548,8 +548,6 @@ def permute_optional_groups(left, required, right):
548548
If required is empty, left must also be empty.
549549
"""
550550
required = tuple(required)
551-
result = []
552-
553551
if not required:
554552
if left:
555553
raise ValueError("required is empty but left is not")
@@ -1338,7 +1336,6 @@ def render_option_group_parsing(self, f, template_dict):
13381336
if isinstance(parameters[0].converter, self_converter):
13391337
del parameters[0]
13401338

1341-
groups = []
13421339
group = None
13431340
left = []
13441341
right = []
@@ -1428,8 +1425,6 @@ def render_function(self, clinic, f):
14281425
first_optional = len(selfless)
14291426
positional = selfless and selfless[-1].is_positional_only()
14301427
new_or_init = f.kind in (METHOD_NEW, METHOD_INIT)
1431-
default_return_converter = (not f.return_converter or
1432-
f.return_converter.type == 'PyObject *')
14331428
has_option_groups = False
14341429

14351430
# offset i by -1 because first_optional needs to ignore self
@@ -1526,7 +1521,6 @@ def render_function(self, clinic, f):
15261521
template_dict['return_value'] = data.return_value
15271522

15281523
# used by unpack tuple code generator
1529-
ignore_self = -1 if isinstance(converters[0], self_converter) else 0
15301524
unpack_min = first_optional
15311525
unpack_max = len(selfless)
15321526
template_dict['unpack_min'] = str(unpack_min)
@@ -1803,10 +1797,8 @@ def is_stop_line(line):
18031797
if self.verify:
18041798
if 'input' in d:
18051799
checksum = d['output']
1806-
input_checksum = d['input']
18071800
else:
18081801
checksum = d['checksum']
1809-
input_checksum = None
18101802

18111803
computed = compute_checksum(output, len(checksum))
18121804
if checksum != computed:
@@ -4243,8 +4235,7 @@ def directive_version(self, required):
42434235
fail("Insufficient Clinic version!\n Version: " + version + "\n Required: " + required)
42444236

42454237
def directive_module(self, name):
4246-
fields = name.split('.')
4247-
new = fields.pop()
4238+
fields = name.split('.')[:-1]
42484239
module, cls = self.clinic._module_and_class(fields)
42494240
if cls:
42504241
fail("Can't nest a module inside a class!")

0 commit comments

Comments
 (0)