Skip to content

Commit a90863c

Browse files
mgornyzware
andauthored
gh-100220: Fix error handling in make rules (GH-100328)
Set `SHELL = /bin/sh -e` to ensure that complex recipes fail on the first error rather than incorrectly reporting success. Co-authored-by: Zachary Ware <[email protected]>
1 parent 2667452 commit a90863c

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

Makefile.pre.in

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ DSYMUTIL_PATH= @DSYMUTIL_PATH@
5959
GNULD= @GNULD@
6060

6161
# Shell used by make (some versions default to the login shell, which is bad)
62-
SHELL= /bin/sh
62+
SHELL= /bin/sh -e
6363

6464
# Use this to make a link between python$(VERSION) and python in $(BINDIR)
6565
LN= @LN@
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Changed the default value of the ``SHELL`` Makefile variable from ``/bin/sh``
2+
to ``/bin/sh -e`` to ensure that complex recipes correctly fail after an error.
3+
Previously, ``make install`` could fail to install some files and yet return
4+
a successful result.

0 commit comments

Comments
 (0)