Address code review

Author: corona10

Modules/readline.c

@@ -1020,7 +1020,7 @@ static int
 #if defined(_RL_FUNCTION_TYPEDEF)
 on_startup_hook(void)
 {
-#elif defined(__APPLE__) && defined(WITH_EDITLINE)
+#elif defined(__APPLE__) && defined(WITH_APPLE_READLINE)
 on_startup_hook(const char *text, int state)
 {
   (void)text;
@@ -1041,7 +1041,7 @@ static int
 #if defined(_RL_FUNCTION_TYPEDEF)
 on_pre_input_hook(void)
 {
-#elif defined(__APPLE__) && defined(WITH_EDITLINE)
+#elif defined(__APPLE__) && defined(WITH_APPLE_READLINE)
 on_pre_input_hook(const char *text, int state)
 {
   (void)text;

configure

@@ -5813,6 +5813,7 @@ dnl library (tinfo ncursesw ncurses termcap). We now assume that libreadline
 dnl or readline.pc provide correct linker information.
 
 AH_TEMPLATE([WITH_EDITLINE], [Define to build the readline module against libedit.])
+AH_TEMPLATE([WITH_APPLE_READLINE], [Define to build the readline module agains apple builtin readline.])
 
 AC_ARG_WITH(
   [readline],
@@ -5832,7 +5833,7 @@ AC_ARG_WITH(
 dnl gh-105323: Need to handle the macOS editline as an alias of readline.
 AS_VAR_IF([with_readline], [default], [
   AS_CASE([$ac_sys_system/$ac_sys_release],
-    [Darwin/*], [AC_DEFINE([WITH_EDITLINE], [1]) with_readline=readline],
+    [Darwin/*], [AC_DEFINE([WITH_APPLE_READLINE], [1]) with_readline=readline],
     [with_readline=readline])
 ])
 

configure.ac

@@ -1791,6 +1791,9 @@
 /* Define if WINDOW in curses.h offers a field _flags. */
 #undef WINDOW_HAS_FLAGS
 
+/* Define to build the readline module agains apple builtin readline. */
+#undef WITH_APPLE_READLINE
+
 /* Define if you want build the _decimal module using a coroutine-local rather
    than a thread-local context */
 #undef WITH_DECIMAL_CONTEXTVAR