From 2e0ecde8d74f5fc0e3e3e39216975cc70efc4796 Mon Sep 17 00:00:00 2001 From: Christian Heimes Date: Tue, 30 Jan 2018 08:55:46 +0100 Subject: [PATCH] bpo-28134: Ignore proto in unknown socket test (GH-5435) Band-aid for macOS: Some platforms seem to ignore unknown protocols. Signed-off-by: Christian Heimes --- Lib/test/test_socket.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py index 89cf1fa520097d..2851922bd0c52b 100644 --- a/Lib/test/test_socket.py +++ b/Lib/test/test_socket.py @@ -1618,7 +1618,7 @@ def test_socket_consistent_sock_type(self): self.assertEqual(s.type, socket.SOCK_STREAM) @unittest.skipIf(os.name == 'nt', 'Will not work on Windows') - def test_uknown_socket_family_repr(self): + def test_unknown_socket_family_repr(self): # Test that when created with a family that's not one of the known # AF_*/SOCK_* constants, socket.family just returns the number. # @@ -1642,7 +1642,8 @@ def test_uknown_socket_family_repr(self): fileno=fd) as s: self.assertEqual(s.family, unknown_family) self.assertEqual(s.type, unknown_type) - self.assertEqual(s.proto, 23) + # some OS like macOS ignore proto + self.assertIn(s.proto, {0, 23}) @unittest.skipUnless(hasattr(os, 'sendfile'), 'test needs os.sendfile()') def test__sendfile_use_sendfile(self):