Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move_on_ and fail_ functions should accept shield as a keyword argument #3052

Closed
agnesnatasya opened this issue Aug 3, 2024 · 0 comments · Fixed by #3051
Closed

move_on_ and fail_ functions should accept shield as a keyword argument #3052

agnesnatasya opened this issue Aug 3, 2024 · 0 comments · Fixed by #3051
Labels
user happiness

Comments

@agnesnatasya
Copy link
Contributor

Support a simpler syntax for:

async with trio.move_on_after(1) as scope:
  scope.shield = True

as a one-liner:

async with trio.move_on_after(1, shield=True) as scope:
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
user happiness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move_on_ and fail_ functions accepts shield kwarg agnesnatasya/trio
2 participants
@TeamSpen210 @agnesnatasya