Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.25.0 Broke support for Windows embedded Python #2987

Closed
richard-lancaster-sp opened this issue Apr 12, 2024 · 1 comment · Fixed by #2979
Closed

v0.25.0 Broke support for Windows embedded Python #2987

richard-lancaster-sp opened this issue Apr 12, 2024 · 1 comment · Fixed by #2979

Comments

@richard-lancaster-sp
Copy link

c:\python-3.11.5-embed-amd64>python.exe -c "import trio; print(trio.__version__)"
0.24.0

c:\python-3.11.5-embed-amd64>python -m pip install trio==v0.25.0
Collecting trio==v0.25.0
... 
Successfully installed trio-0.25.0

c:\python-3.11.5-embed-amd64>python.exe -c "import trio; print(trio.__version__)"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "c:\python-3.11.5-embed-amd64\Lib\site-packages\trio\__init__.py", line 76, in <module>
    from ._path import Path as Path, PosixPath as PosixPath, WindowsPath as WindowsPath
  File "c:\python-3.11.5-embed-amd64\Lib\site-packages\trio\_path.py", line 99, in <module>
    class Path(pathlib.PurePath):
  File "c:\python-3.11.5-embed-amd64\Lib\site-packages\trio\_path.py", line 116, in Path
    @_wraps_async(pathlib.Path.cwd)
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\python-3.11.5-embed-amd64\Lib\site-packages\trio\_path.py", line 41, in decorator
    assert wrapped.__doc__ is not None
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

c:\python-3.11.5-embed-amd64>

We're using trio and Windows embedded python (https://www.python.org/downloads/windows/), v0.25.0 broke support for this version of python as it assumes the inclusion of doc strings.

@jakkdl
Copy link
Member

jakkdl commented Apr 12, 2024

Fixed by #2979

(duplicate of it, except it didn't start as an issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants