Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removal newsfragments do not show in history #2846

Closed
richardsheridan opened this issue Oct 31, 2023 · 2 comments · Fixed by #2850
Closed

removal newsfragments do not show in history #2846

richardsheridan opened this issue Oct 31, 2023 · 2 comments · Fixed by #2850

Comments

@richardsheridan
Copy link
Contributor

We have several removals pending and I was directed to make one in #2841, but removal is not a valid towncrier type right now. Do we want to rename newsfragments, or add removal and remove deprecated, or maybe there is a way to alias them?
@A5rocks
Copy link
Contributor

A5rocks commented Oct 31, 2023

Yeah I noticed this and my conclusion is we should add a new removal type that mirrors deprecated. If you check the readme in the newsfragments folder it mentions both are for different things after all.

@oremanj
Copy link
Member

oremanj commented Oct 31, 2023

My suggestion of removal in the cancellable -> abandon_on_cancel diff was incorrect; that should have been deprecated. I got confused by the other removal newsfragments, which I agree that we should support.

@A5rocks A5rocks mentioned this issue Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add removals as a newsfragment type A5rocks/trio
3 participants
@oremanj @richardsheridan @A5rocks